Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MDs and release publishing files to reflect the repo move to OWF #3270

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

swcurran
Copy link
Contributor

@swcurran swcurran commented Oct 3, 2024

A complementary PR to the one that @jamshale made - #3267. His moves the technical components -- code and GHAs -- while this one focuses on documentation and the release/publishing process. I don't think there is a lot of overlap between them -- hopefully none.

Signed-off-by: Stephen Curran [email protected]

@swcurran swcurran changed the title [DO NOT MERGE] Prepare MD and release publishing files for the repo move to OWF Update MDs and release publishing files to reflect the repo move to OWF Oct 9, 2024
@swcurran swcurran marked this pull request as ready for review October 9, 2024 15:57
@swcurran swcurran requested review from a team October 9, 2024 15:57
Copy link
Contributor

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use relative links to the various files rather than an explicit URL? Since you're having to update all the references anyway, it may be a good time to do this.

@swcurran
Copy link
Contributor Author

swcurran commented Oct 9, 2024

It is not always straight forward. The links have to work in both the GitHub repo context and on https://aca-py.org, so there are places where I just use the hardcoded link (as you have seen), some where there is an update made to the link in generating the gh-pages site, and others that “just work”. Things that ONLY exist in the GitHub repo MUST be absolute links for them to work on the gh-pages site. I did clean up a bunch of them in this PR, but not all can be done.

So, bottom line, no.

sonar-project.properties Outdated Show resolved Hide resolved
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than that one sonarcloud config file.

Signed-off-by: Stephen Curran <[email protected]>
@swcurran swcurran requested review from jamshale, WadeBarnes and a team October 9, 2024 16:20
@swcurran swcurran merged commit 2dbea90 into openwallet-foundation:main Oct 9, 2024
8 checks passed
@swcurran swcurran deleted the move-to-owf branch October 9, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants